Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Improve SAML metadata handling of SAML IdP

Description

SAML subsystem uses Properties (wrapped with PropertiesHelper) both for configuration parsing and runtime configuration. The latter is created by converting all trusted SAML entities from metadata into individually configured entities in the properties, i.e. for each entity series of properties is added.

The task is to introduce a proper immutable types to represent trusted SPs and use it at runtime instead of so called “effective” properties. Of course accompanying collection holder with fast retrieval is also needed.

Key class to be completely dropped is MetaToIDPConfigConverter.

Activity

Krzysztof January 9, 2023 at 11:58 AM

QA #2: +1

Krzysztof December 6, 2022 at 3:00 PM
Edited

QA:

In general seems good, basic tests worked fine. I’ve found some problems around functionality to fetch trusted SPs. Might be regressions or not.

  1. Configure in console a trusted federation but with invalid (not existing) file URL. Click fetch. Error is shown (correct) but also polling is not cancelled, note infinite requests stream from UI.

  2. In console, in Identity Provider → endpoints we can select SAML IdP. Add edugain to trusted federations of this IdP. Save. Then open again open that federation and go to Federation’s service providers, click Fetch.

    1. Results are suboptimal, operation is blocked until all logos are fetched (which are refetched after each click). This should not happen for sure.

    2. What is more maybe we can just show what was already downloaded? then fetch would just trigger re-fetch but UI would show what is installed.

    3. The grid is not working reliably. Sth is wrong: after some scrolling it gets empty. And is in general terribly slow.

Roman Krysiński November 27, 2022 at 6:05 PM

RK QA: +1

Done

Details

Assignee

Reporter

Area

Fix versions

Priority

Created March 30, 2022 at 11:53 AM
Updated January 9, 2023 at 11:58 AM
Resolved January 9, 2023 at 11:58 AM